Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165693003: Cast: added missing include in simple_event_subscriber.h. (Closed)

Created:
6 years, 10 months ago by imcheng
Modified:
6 years, 10 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org, erickung1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cast: added missing include in simple_event_subscriber.h. Some build envs don't understand OVERRIDE without that header. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/cast/logging/simple_event_subscriber.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
imcheng
6 years, 10 months ago (2014-02-14 01:39:01 UTC) #1
Alpha Left Google
On 2014/02/14 01:39:01, imcheng1 wrote: LGTM.
6 years, 10 months ago (2014-02-14 18:27:24 UTC) #2
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-14 18:43:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/165693003/1
6 years, 10 months ago (2014-02-14 18:45:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-14 20:27:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=264534
6 years, 10 months ago (2014-02-14 20:27:39 UTC) #6
imcheng
The CQ bit was checked by imcheng@chromium.org
6 years, 10 months ago (2014-02-14 20:42:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/imcheng@chromium.org/165693003/1
6 years, 10 months ago (2014-02-14 20:44:41 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 00:55:39 UTC) #9
Message was sent while issue was closed. 
Change committed as 251463

Powered by Google App Engine
This is Rietveld 408576698