Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/core/dart/DartInspectorConsoleMessage.cpp

Issue 1656913004: Fix all remaining link and compile errors building dartium 45 both in Release and Debug. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/dart/DartInspectorConsoleMessage.cpp
diff --git a/Source/bindings/core/dart/DartInspectorConsoleMessage.cpp b/Source/bindings/core/dart/DartInspectorConsoleMessage.cpp
index c56b7b04fe13c18f1493f97fded0530ac4ee3279..7a803c6d052a79c038d1f504c0861d15a2fd3729 100644
--- a/Source/bindings/core/dart/DartInspectorConsoleMessage.cpp
+++ b/Source/bindings/core/dart/DartInspectorConsoleMessage.cpp
@@ -43,8 +43,11 @@
namespace blink {
+// TODO(jacobr): this method is basically obsolete with dart:html implemented on top of JS interop.
void DartInspectorConsoleMessage::addToFrontend(InspectorFrontend::Console* frontend, InjectedScriptManager* injectedScriptManager, bool generatePreview, ConsoleMessage* consoleMessage, PassRefPtr<TypeBuilder::Console::ConsoleMessage> jsonObj)
{
+ ASSERT_NOT_REACHED();
+ /*
DartScriptState* scriptState = DartUtilities::currentDartScriptState();
ASSERT(scriptState != 0);
@@ -61,11 +64,7 @@ void DartInspectorConsoleMessage::addToFrontend(InspectorFrontend::Console* fron
if (consoleMessage->type() == TableMessageType && generatePreview && consoleMessage->scriptArguments()->argumentCount()) {
ScriptValue table = consoleMessage->scriptArguments()->argumentAt(0);
ScriptValue columns = consoleMessage->scriptArguments()->argumentCount() > 1 ? consoleMessage->scriptArguments()->argumentAt(1) : ScriptValue();
- RefPtr<TypeBuilder::Runtime::RemoteObject> inspectorValue = injectedScript->wrapTable(table, columns);
- if (!inspectorValue) {
- ASSERT_NOT_REACHED();
- return;
- }
+ ASSERT_NOT_REACHED();
jsonArgs->addItem(inspectorValue);
} else {
for (unsigned i = 0; i < consoleMessage->scriptArguments()->argumentCount(); ++i) {
@@ -98,6 +97,7 @@ void DartInspectorConsoleMessage::addToFrontend(InspectorFrontend::Console* fron
}
frontend->messageAdded(jsonObj);
frontend->flush();
+ */
}
} // namespace blink
« no previous file with comments | « Source/bindings/core/dart/DartInjectedScript.cpp ('k') | Source/bindings/core/dart/DartInspectorDebuggerAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698