Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: Source/bindings/core/dart/DartInjectedScript.cpp

Issue 1656913004: Fix all remaining link and compile errors building dartium 45 both in Release and Debug. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1371 matching lines...) Expand 10 before | Expand all | Expand 10 after
1382 return wrapDartHandle(dartHandle, inferKind(dartHandle), groupName, generate Preview); 1382 return wrapDartHandle(dartHandle, inferKind(dartHandle), groupName, generate Preview);
1383 } 1383 }
1384 1384
1385 PassRefPtr<TypeBuilder::Runtime::RemoteObject> DartInjectedScript::wrapDartHandl e(Dart_Handle dartHandle, DartDebuggerObject::Kind kind, const String& groupName , bool generatePreview) 1385 PassRefPtr<TypeBuilder::Runtime::RemoteObject> DartInjectedScript::wrapDartHandl e(Dart_Handle dartHandle, DartDebuggerObject::Kind kind, const String& groupName , bool generatePreview)
1386 { 1386 {
1387 RefPtr<TypeBuilder::Runtime::RemoteObject> remoteObject; 1387 RefPtr<TypeBuilder::Runtime::RemoteObject> remoteObject;
1388 packageResult(dartHandle, kind, groupName, 0, false, generatePreview, &remot eObject, 0); 1388 packageResult(dartHandle, kind, groupName, 0, false, generatePreview, &remot eObject, 0);
1389 return remoteObject; 1389 return remoteObject;
1390 } 1390 }
1391 1391
1392 PassRefPtr<TypeBuilder::Runtime::RemoteObject> DartInjectedScript::wrapTable(con st ScriptValue& table, const ScriptValue& columns)
1393 {
1394 if (!m_scriptState)
1395 return nullptr;
1396 DartIsolateScope scope(m_scriptState->isolate());
1397 DartApiScope apiScope;
1398 // FIXME: implement this rarely used method or call out to the JS version.
1399 ASSERT_NOT_REACHED();
1400 return nullptr;
1401 }
1402
1403 ScriptValue DartInjectedScript::findObjectById(const String& objectId) const 1392 ScriptValue DartInjectedScript::findObjectById(const String& objectId) const
1404 { 1393 {
1405 // FIXMEDART: Implement this. 1394 // FIXMEDART: Implement this.
1406 RELEASE_ASSERT(0); 1395 RELEASE_ASSERT(0);
1407 return ScriptValue(); 1396 return ScriptValue();
1408 } 1397 }
1409 1398
1410 void DartInjectedScript::inspectNode(Node* node) 1399 void DartInjectedScript::inspectNode(Node* node)
1411 { 1400 {
1412 // FIXMEDART: Implement this. 1401 // FIXMEDART: Implement this.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
1451 RefPtr<JSONValue> parsedObjectId = parseJSON(objectId); 1440 RefPtr<JSONValue> parsedObjectId = parseJSON(objectId);
1452 if (parsedObjectId && parsedObjectId->type() == JSONValue::TypeObject) { 1441 if (parsedObjectId && parsedObjectId->type() == JSONValue::TypeObject) {
1453 bool isDart = false; 1442 bool isDart = false;
1454 bool success = parsedObjectId->asObject()-> getBoolean("isDart", &isDart ); 1443 bool success = parsedObjectId->asObject()-> getBoolean("isDart", &isDart );
1455 return success && isDart; 1444 return success && isDart;
1456 } 1445 }
1457 return false; 1446 return false;
1458 } 1447 }
1459 1448
1460 } // namespace blink 1449 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/dart/DartInjectedScript.h ('k') | Source/bindings/core/dart/DartInspectorConsoleMessage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698