ppapi/native_client/src/trusted/plugin/plugin.cc - Issue 16569002: Use HTTP response headers for PNaCl caching instead of bitcode hash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/plugin.cc

Issue 16569002: Use HTTP response headers for PNaCl caching instead of bitcode hash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cleanup Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/native_client/src/trusted/plugin/file_downloader.cc ('K') | « ppapi/native_client/src/trusted/plugin/nacl_http_response_headers_unittest.cc ('k') | ppapi/native_client/src/trusted/plugin/plugin.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/trusted/plugin/plugin.cc

diff --git a/ppapi/native_client/src/trusted/plugin/plugin.cc b/ppapi/native_client/src/trusted/plugin/plugin.cc

index cd5dfbf06cd2e37d200376e7d82ec66da31ee7e6..5d311288c0f84ef5635c6639307d5b9aac915d9a 100644

--- a/ppapi/native_client/src/trusted/plugin/plugin.cc

+++ b/ppapi/native_client/src/trusted/plugin/plugin.cc

@@ -1185,7 +1185,8 @@ void Plugin::ProcessNaClManifest(const nacl::string& manifest_json) {

DOWNLOAD_TO_FILE,

open_callback,

true,

- &UpdateDownloadProgress));

+ &UpdateDownloadProgress,

+ true));

}

return;

}

@@ -1230,7 +1231,8 @@ void Plugin::RequestNaClManifest(const nacl::string& url) {

DOWNLOAD_TO_BUFFER,

open_callback,

false,

- NULL));

+ NULL,

+ true));

} else {

pp::CompletionCallback open_callback =

callback_factory_.NewCallback(&Plugin::NaClManifestFileDidOpen);

@@ -1239,7 +1241,8 @@ void Plugin::RequestNaClManifest(const nacl::string& url) {

DOWNLOAD_TO_FILE,

open_callback,

false,

- NULL));

+ NULL,

+ true));

}

@@ -1331,7 +1334,8 @@ bool Plugin::StreamAsFile(const nacl::string& url,

DOWNLOAD_TO_FILE,

open_callback,

true,

- &UpdateDownloadProgress);

+ &UpdateDownloadProgress,

+ true);

}