Issue 16569: Allowing the year 2009 in copyright notices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16569: Allowing the year 2009 in copyright notices. (Closed)

Created:
11 years, 11 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee, Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Allowing the year 2009 in copyright notices.

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/presubmit.py	View		1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

http://codereview.chromium.org/16569/diff/1/2 File tools/presubmit.py (right): http://codereview.chromium.org/16569/diff/1/2#newcode154 Line 154: r'Copyright [\d-]*200[8,9] the V8 project authors. All rights ...

11 years, 11 months ago (2009-01-07 11:42:14 UTC) #3

olehougaard

11 years, 11 months ago (2009-01-07 11:54:45 UTC) #4

http://codereview.chromium.org/16569/diff/1/2
File tools/presubmit.py (right):

http://codereview.chromium.org/16569/diff/1/2#newcode154
Line 154: r'Copyright [\d-]*200[8,9] the V8 project authors. All rights
reserved.')
On 2009/01/07 11:42:15, Dean McNamee wrote:
> Doesn't this make 200, a valid year?

So what's wrong with that?

Okay, I guess, I suck. I'm withdrawing this since Mads has already fixed it
(correctly).

Expand Messages | Collapse Messages