third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js - Issue 1656823002: Add layout tests for ServiceWorker's notificationclose event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

Issue 1656823002: Add layout tests for ServiceWorker's notificationclose event. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now the test actually works Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/layout_test/layout_test_notification_manager.cc ('K') | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclose-event-data-reflection.html » ('j') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notificationclose-event-data-reflection.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js b/third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

index a46fa7b04847fdcd0f8aa4eeb328a225f5d2fec4..dba8725f6fb2071cdebf128ae4b4e3fe54bd4b7b 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/resources/instrumentation-service-worker.js

@@ -102,3 +102,9 @@ addEventListener('notificationclick', function(event) {

notification: notificationCopy,

action: event.action });

});

+addEventListener('notificationclose', function(event) {

+ var notificationCopy = cloneNotification(event.notification);

+ messagePort.postMessage({ command: 'close',

+ notification: notificationCopy});

Peter Beverloo 2016/02/02 23:50:10 micro nit: space before }

Nina 2016/02/03 15:04:23 Done.

+});