third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp - Issue 1656743002: Removing more implicit LayoutUnit construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

Issue 1656743002: Removing more implicit LayoutUnit construction (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix additional test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp b/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

index 24a41842bca3eecb1dfa6ca92874912d46befbf6..15e67cd1ad007cba8b16e4ac6eab1a9bd48611c8 100644

--- a/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp

@@ -971,10 +971,10 @@ void BoxBorderPainter::drawBoxSideFromPath(GraphicsContext& graphicsContext,

// Paint inner only

GraphicsContextStateSaver stateSaver(graphicsContext);

- LayoutUnit topWidth = m_edges[BSTop].usedWidth() / 2;

- LayoutUnit bottomWidth = m_edges[BSBottom].usedWidth() / 2;

- LayoutUnit leftWidth = m_edges[BSLeft].usedWidth() / 2;

- LayoutUnit rightWidth = m_edges[BSRight].usedWidth() / 2;

+ LayoutUnit topWidth(m_edges[BSTop].usedWidth() / 2);

+ LayoutUnit bottomWidth(m_edges[BSBottom].usedWidth() / 2);

+ LayoutUnit leftWidth(m_edges[BSLeft].usedWidth() / 2);

+ LayoutUnit rightWidth(m_edges[BSRight].usedWidth() / 2);

FloatRoundedRect clipRect = m_style.getRoundedInnerBorderFor(borderRect,

LayoutRectOutsets(-topWidth, -rightWidth, -bottomWidth, -leftWidth),