tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py - Issue 165673008: [telemetry] Implement first version of timeline based measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py

Issue 165673008: [telemetry] Implement first version of timeline based measurement (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/perf/measurements/meta_measurement.py ('K') | « tools/perf/metrics/timeline_based_metric.py ('k') | tools/telemetry/telemetry/core/timeline/async_slice.py » ('j') | tools/telemetry/unittest_data/measurement_request_enabled_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py

index 4631814ad4400871ba60c97c7e387ea05320b3a5..0d9cfd118a47d5cd192b02b680f43836d3fd5922 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_trace_result.py

@@ -27,8 +27,10 @@ class ChromeTraceResult(object):

for key, value in self._tab_to_marker_mapping.iteritems():

timeline_markers = timeline.FindTimelineMarkers(value)

assert(len(timeline_markers) == 1)

- renderer_process = timeline_markers[0].start_thread.parent

- timeline.AddCoreObjectToContainerMapping(key, renderer_process)

+ assert(timeline_markers[0].start_thread ==

+ timeline_markers[0].end_thread)

+ renderer_thread = timeline_markers[0].start_thread

+ timeline.AddCoreObjectToContainerMapping(key, renderer_thread)

return timeline

def _CreateTimelineModel(self):