Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 165673003: Fix for ANGLE interface error (Closed)

Created:
6 years, 10 months ago by egdaniel
Modified:
6 years, 10 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix for ANGLE interface error NOTREECHECKS=True NOTRY=True TBR=bsalomon@google.com BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13541

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/gpu/gl/angle/GrGLCreateANGLEInterface.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 19:29:49 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 19:29:53 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 19:29:53 UTC) #3
egdaniel
6 years, 10 months ago (2014-02-21 19:30:23 UTC) #4
bsalomon
lgtm
6 years, 10 months ago (2014-02-21 19:39:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/165673003/1
6 years, 10 months ago (2014-02-21 19:39:31 UTC) #6
egdaniel
The CQ bit was unchecked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 19:44:01 UTC) #7
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 19:44:03 UTC) #8
egdaniel
The CQ bit was unchecked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 19:45:21 UTC) #9
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 10 months ago (2014-02-21 19:46:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/165673003/1
6 years, 10 months ago (2014-02-21 19:46:17 UTC) #11
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 19:46:23 UTC) #12
Message was sent while issue was closed.
Change committed as 13541

Powered by Google App Engine
This is Rietveld 408576698