Factor out MockThreadableLoader

Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
R=hiroshige,japhet

Committed: https://crrev.com/2efae69b4079c7fde06fe2ef8eb320744665db6b
Cr-Commit-Position: refs/heads/master@{#374626}

[tyoshino (SeeGerritForStatus), 2016-02-01 12:43:21]

Description was changed from

==========
Factor out MockThreadableLoader

BUG=none
==========

to

==========
Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
==========

[tyoshino (SeeGerritForStatus), 2016-02-01 12:43:22]

tyoshino@chromium.org changed reviewers:
+ hiroshige@chromium.org

[tyoshino (SeeGerritForStatus), 2016-02-01 12:47:22]

Forgot to include an include guard. Fixed.

[hiroshige, 2016-02-05 05:31:46]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 05:32:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656673003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656673003/20001

[hiroshige, 2016-02-05 05:42:09]

lgtm.

Optionally we can set BUG=518855 in the CL description.

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/MockThreadableLoader.h (right):

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/MockThreadableLoader.h:18:
MOCK_METHOD1(start, void(const ResourceRequest&));
If we land this CL before https://codereview.chromium.org/1264453002, then it
would be better to remove start() from this CL, and then add start() here (and
EXPECT_CALL(..., start)) in https://codereview.chromium.org/1264453002.

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
(right):

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp:53:
EXPECT_CALL(*loader, cancel()).Times(1);
nit: perhaps it would be better to place EXPECT_CALL before
didReceiveResponse()?

[commit-bot: I haz the power, 2016-02-05 06:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 06:27:30]

Dry run: This issue passed the CQ dry run.

[tyoshino (SeeGerritForStatus), 2016-02-05 07:22:10]

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/MockThreadableLoader.h (right):

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/MockThreadableLoader.h:18:
MOCK_METHOD1(start, void(const ResourceRequest&));
On 2016/02/05 at 05:42:09, hiroshige wrote:
> If we land this CL before https://codereview.chromium.org/1264453002, then it
would be better to remove start() from this CL, and then add start() here (and
EXPECT_CALL(..., start)) in https://codereview.chromium.org/1264453002.

Oh, right. I forgot to make it consistent with ToT. Fixed.

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp
(right):

https://codereview.chromium.org/1656673003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp:53:
EXPECT_CALL(*loader, cancel()).Times(1);
On 2016/02/05 at 05:42:09, hiroshige wrote:
> nit: perhaps it would be better to place EXPECT_CALL before
didReceiveResponse()?

I see. Fixed

[tyoshino (SeeGerritForStatus), 2016-02-05 07:22:54]

tyoshino@chromium.org changed reviewers:
+ japhet@chromium.org

[tyoshino (SeeGerritForStatus), 2016-02-05 07:23:06]

+japhet for OWNER review

[tyoshino (SeeGerritForStatus), 2016-02-05 07:23:20]

The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 07:23:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656673003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656673003/40001

[commit-bot: I haz the power, 2016-02-05 08:22:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 08:22:51]

Dry run: This issue passed the CQ dry run.

[Nate Chapin, 2016-02-09 19:25:22]

lgtm

[tyoshino (SeeGerritForStatus), 2016-02-10 06:49:52]

Description was changed from

==========
Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
==========

to

==========
Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
R=hiroshige,japhet
==========

[tyoshino (SeeGerritForStatus), 2016-02-10 07:26:12]

The CQ bit was checked by tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-02-10 07:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1656673003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-02-10 07:26:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1656673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1656673003/60001

[commit-bot: I haz the power, 2016-02-10 08:07:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-10 08:09:03]

Description was changed from

==========
Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
R=hiroshige,japhet
==========

to

==========
Factor out MockThreadableLoader

Split from https://codereview.chromium.org/1264453002

BUG=none
R=hiroshige,japhet

Committed: https://crrev.com/2efae69b4079c7fde06fe2ef8eb320744665db6b
Cr-Commit-Position: refs/heads/master@{#374626}
==========

[commit-bot: I haz the power, 2016-02-10 08:09:04]

Patchset 4 (id:??) landed as
https://crrev.com/2efae69b4079c7fde06fe2ef8eb320744665db6b
Cr-Commit-Position: refs/heads/master@{#374626}