Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1656493002: Switching foreign function to be marked as functions at call sites. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switching foreign function to be marked as functions at call sites. On further reflection, marking the variable proxy at call sites for foreign functions as a function is ok. Switching this. Fixed a few IntersectResults that probably should be an explicit set_bounds. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/83744a4bee007b44dcd283ae3d71384856063bae Cr-Commit-Position: refs/heads/master@{#33623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/typing-asm.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
bradn
4 years, 10 months ago (2016-01-30 02:06:11 UTC) #3
aseemgarg
lgtm
4 years, 10 months ago (2016-01-30 02:07:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656493002/1
4 years, 10 months ago (2016-01-30 02:08:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 02:38:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 02:38:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83744a4bee007b44dcd283ae3d71384856063bae
Cr-Commit-Position: refs/heads/master@{#33623}

Powered by Google App Engine
This is Rietveld 408576698