runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart - Issue 1656483002: If testeeBefore returns a future, wait for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart

Issue 1656483002: If testeeBefore returns a future, wait for it. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/get_allocation_samples_test.dart ('k') | runtime/observatory/tests/service/test_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart

diff --git a/runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart b/runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart

index 4a6b2ddf2ac8656976fd7f6151a132bc987e6ab7..e9f233b85bde4aab15e3a0f23fb1cfbbbd835fcd 100644

--- a/runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart

+++ b/runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart

@@ -15,13 +15,15 @@ doThrow() {

var tests = [

hasStoppedWithUnhandledException,

(Isolate isolate) async {

+ print("We stoppped!");

var stack = await isolate.getStack();

expect(stack['frames'][0].function.name, equals('doThrow'));

}

];

-main(args) => runIsolateTests(args,

- tests,

- pause_on_unhandled_exceptions: true,

- testeeConcurrent: doThrow);

+main(args) => runIsolateTestsSynchronous(args,

+ tests,

+ pause_on_unhandled_exceptions: true,

+ testeeConcurrent: doThrow);