Issue 1656483002: If testeeBefore returns a future, wait for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1656483002: If testeeBefore returns a future, wait for it. (Closed)

Created:
4 years, 10 months ago by turnidge

Modified:
4 years, 10 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

If testeeBefore returns a future, wait for it. This fixes some flakiness in a bunch of service tests that assumed this would work. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/dacb44079a52cc39f5178997ff1c3dfc18d8a00d

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -14 lines)			Patch
M	runtime/observatory/tests/service/get_allocation_samples_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/observatory/tests/service/pause_on_unhandled_exceptions_test.dart	View		1 chunk	+6 lines, -4 lines	0 comments	Download
M	runtime/observatory/tests/service/test_helper.dart	View	1	1 chunk	+80 lines, -9 lines	0 comments	Download

Total messages: 5 (2 generated)

turnidge

4 years, 10 months ago (2016-01-30 00:41:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
dacb44079a52cc39f5178997ff1c3dfc18d8a00d (presubmit successful).