Issue 16564006: Test theory for Android FrameTreeNode crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16564006: Test theory for Android FrameTreeNode crash. (Closed)

Created:
7 years, 6 months ago by Charlie Reis

Modified:
7 years, 6 months ago

Reviewers:
awong, nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, bengr

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Test theory for Android FrameTreeNode crash. BUG=247807 [Replaced by http://crrev.com/205929]

Patch Set 1 #

Patch Set 2 : Try fischman's build file change #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	content/content_tests.gypi	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

7 years, 6 months ago (2013-06-07 04:54:45 UTC) #1

Well, this narrows down the cause of the failure in
https://codereview.chromium.org/15682009/.  Any change to the layout of
WebContents (above frame_tree_root_) seems to be breaking the FrameTreeShape
test on Android.

After talking with Albert, my best guess is that it's a failed compiler
optimization in scoped_ptr, but maybe that's way off.  I'll try to work around
it in the original CL and we can diagnose this separately, since anyone who
changes WebContents right now risks hitting this.

Expand Messages | Collapse Messages