Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1656303002: Revert of Avoid too small reads to bufferMoreData() (Closed)

Created:
4 years, 10 months ago by jcgregorio
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo, yujieqin
CC:
reviews_skia.org, adaubert
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Avoid too small reads to bufferMoreData() (patchset #4 id:60001 of https://codereview.chromium.org/1644893003/ ) Reason for revert: Crashed both Nexus 5s: https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release/builds/3355 https://build.chromium.org/p/client.skia.android/builders/Perf-Android-GCC-Nexus5-CPU-NEON-Arm7-Release/builds/3354 Original issue's description: > Avoid too small reads to bufferMoreData() > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644893003 > > Committed: https://skia.googlesource.com/skia/+/fd918e8c739065fa467cf6614181d3a2c5dcadcb TBR=msarett@google.com,scroggo@google.com,yujieqin@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2ac722f1f8b675eebc89ca1c2d7d44cfc887b58a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/codec/SkRawCodec.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jcgregorio
Created Revert of Avoid too small reads to bufferMoreData()
4 years, 10 months ago (2016-02-02 13:35:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656303002/1
4 years, 10 months ago (2016-02-02 13:36:05 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 13:36:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ac722f1f8b675eebc89ca1c2d7d44cfc887b58a

Powered by Google App Engine
This is Rietveld 408576698