tools/gn/ninja_target_writer.cc - Issue 1656253003: [GN] Don't rewrite files with the same contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1656253003: [GN] Don't rewrite files with the same contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test on Mac Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_target_writer.cc

diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc

index 7d9c08afd65bdcb7741b52f8633ada63bfd56b79..9f19b2b0065321d12f74279d97dfbe492cf5ecc1 100644

--- a/tools/gn/ninja_target_writer.cc

+++ b/tools/gn/ninja_target_writer.cc

@@ -74,9 +74,7 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {

CHECK(0) << "Output type of target not handled.";

}

- std::string contents = file.str();

- base::WriteFile(ninja_file, contents.c_str(),

- static_cast<int>(contents.size()));

+ WriteFileIfChanged(ninja_file, file.str(), nullptr);

}

void NinjaTargetWriter::WriteEscapedSubstitution(SubstitutionType type) {

« no previous file with comments | « tools/gn/function_write_file.cc ('k') | tools/gn/visual_studio_writer.cc » ('j') | no next file with comments »