[GN] Don't rewrite files with the same contents

tools/gn/filesystem_utils.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/filesystem_utils.h"
 
 #include <algorithm>
 
 #include "base/files/file_util.h"
 #include "base/logging.h"
@@ skipping 669 matching lines @@
 std::string GetOutputSubdirName(const Label& toolchain_label, bool is_default) {
   // The default toolchain has no subdir.
   if (is_default)
     return std::string();
 
   // For now just assume the toolchain name is always a valid dir name. We may
   // want to clean up the in the future.
   return toolchain_label.name() + "/";
 }
 
+bool ContentsEqual(const base::FilePath& file_path, std::stringstream* data) {

[brettw, 2016/02/02 20:50:23]

I'm thinking it might be better if this took a std::string as input so we can
avoid making a string twice out of the stringstream (these will be big strings
so we want to avoid duplicates)

[Tomasz Moniuszko, 2016/02/03 10:20:30]

Done.

+  // Compare file and stream sizes first. Quick and will save us some time if
+  // they are different sizes.
+  int64_t data_size = data->tellp();
+
+  int64_t file_size;
+  if (!base::GetFileSize(file_path, &file_size) || file_size != data_size)
+    return false;
+
+  std::string file_data;
+  file_data.resize(file_size);
+  if (!base::ReadFileToString(file_path, &file_data))
+    return false;
+
+  return file_data == data->str();
+}
+
+bool WriteFileIfChanged(const base::FilePath& file_path,
+                        std::stringstream* data) {
+  if (ContentsEqual(file_path, data))
+    return true;
+
+  std::string data_str = data->str();
+  int size = static_cast<int>(data_str.size());
+  return base::WriteFile(file_path, data_str.c_str(), size) == size;
+}
+
 SourceDir GetToolchainOutputDir(const Settings* settings) {
   return settings->toolchain_output_subdir().AsSourceDir(
       settings->build_settings());
 }
 
 SourceDir GetToolchainOutputDir(const BuildSettings* build_settings,
                                 const Label& toolchain_label, bool is_default) {
   std::string result = build_settings->build_dir().value();
   result.append(GetOutputSubdirName(toolchain_label, is_default));
   return SourceDir(SourceDir::SWAP_IN, &result);
@@ skipping 135 matching lines @@
 
 SourceDir GetCurrentOutputDir(const Scope* scope) {
   return GetOutputDirForSourceDirAsOutputFile(
       scope->settings(), scope->GetSourceDir()).AsSourceDir(
           scope->settings()->build_settings());
 }
 
 SourceDir GetCurrentGenDir(const Scope* scope) {
   return GetGenDirForSourceDir(scope->settings(), scope->GetSourceDir());
 }