third_party/WebKit/Source/modules/notifications/NotificationOptions.idl - Issue 1656243002: Implementation of renotify flag for Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TypeError for incorrect options and unit test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/NotificationData.cpp ('K') | « third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

index 1e3e130f1fee511036b869c656946cea5039e618..02da479fa4f64c0aaa86239b81c32d2f9f889f9f 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

+++ b/third_party/WebKit/Source/modules/notifications/NotificationOptions.idl

@@ -20,6 +20,7 @@ dictionary NotificationOptions {

(unsigned long or sequence<unsigned long>) vibrate;

DOMTimeStamp timestamp;

boolean silent = false;

+ boolean renotify = false;

boolean requireInteraction = false;

any data = null;

sequence<NotificationAction> actions = [];