Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TypeError for incorrect options and unit test Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
index 8f58d30cb08c6c5f4e6d0db2e51cd15c91c50ac8..7e6e0668b638591a188a52253832398ae02106b8 100644
--- a/content/child/notifications/notification_data_conversions_unittest.cc
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -43,6 +43,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));
web_data.timestamp = kNotificationTimestamp;
web_data.silent = true;
+ web_data.renotify = true;
web_data.requireInteraction = true;
web_data.data =
blink::WebVector<char>(kNotificationData, arraysize(kNotificationData));
@@ -63,6 +64,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
EXPECT_EQ(kNotificationTag, platform_data.tag);
EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
EXPECT_TRUE(platform_data.silent);
+ EXPECT_TRUE(platform_data.renotify);
EXPECT_TRUE(platform_data.require_interaction);
EXPECT_THAT(platform_data.vibration_pattern,

Powered by Google App Engine
This is Rietveld 408576698