content/browser/notifications/notification_database_data_unittest.cc - Issue 1656243002: Implementation of renotify flag for Notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database_data_unittest.cc

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TypeError for incorrect options and unit test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/notification_database_data.proto ('K') | « content/browser/notifications/notification_database_data_conversions.cc ('k') | content/child/notifications/notification_data_conversions.cc » ('j') | third_party/WebKit/Source/modules/notifications/NotificationData.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database_data_unittest.cc

diff --git a/content/browser/notifications/notification_database_data_unittest.cc b/content/browser/notifications/notification_database_data_unittest.cc

index 4765dba2241c495f80845b8fa443539565164a7a..69b90b3e3b05cca30949f166b10c4d41a634fa81 100644

--- a/content/browser/notifications/notification_database_data_unittest.cc

+++ b/content/browser/notifications/notification_database_data_unittest.cc

@@ -50,6 +50,7 @@ TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {

notification_data.vibration_pattern = vibration_pattern;

notification_data.timestamp = base::Time::FromJsTime(kNotificationTimestamp);

notification_data.silent = true;

+ notification_data.renotify = true;

notification_data.require_interaction = true;

notification_data.data = developer_data;

for (size_t i = 0; i < kPlatformNotificationMaxActions; i++) {

@@ -97,6 +98,7 @@ TEST(NotificationDatabaseDataTest, SerializeAndDeserializeData) {

EXPECT_EQ(notification_data.timestamp, copied_notification_data.timestamp);

EXPECT_EQ(notification_data.silent, copied_notification_data.silent);

+ EXPECT_EQ(notification_data.renotify, copied_notification_data.renotify);

EXPECT_EQ(notification_data.require_interaction,

copied_notification_data.require_interaction);