Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: content/child/notifications/notification_data_conversions_unittest.cc

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_data_conversions_unittest.cc
diff --git a/content/child/notifications/notification_data_conversions_unittest.cc b/content/child/notifications/notification_data_conversions_unittest.cc
index 090dd039a325ad3e98f392f672e8725bc8cb69fd..67b704e456b676e4fdaef1a7e3223f0d0d2a1ea3 100644
--- a/content/child/notifications/notification_data_conversions_unittest.cc
+++ b/content/child/notifications/notification_data_conversions_unittest.cc
@@ -44,6 +44,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
web_data.vibrate = blink::WebVector<int>(
kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));
web_data.timestamp = kNotificationTimestamp;
+ web_data.renotify = true;
web_data.silent = true;
web_data.requireInteraction = true;
web_data.data =
@@ -66,6 +67,7 @@ TEST(NotificationDataConversionsTest, ToPlatformNotificationData) {
EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);
EXPECT_EQ(kNotificationTag, platform_data.tag);
EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
+ EXPECT_TRUE(platform_data.renotify);
EXPECT_TRUE(platform_data.silent);
EXPECT_TRUE(platform_data.require_interaction);
@@ -102,6 +104,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
platform_data.icon = GURL(kNotificationIconUrl);
platform_data.vibration_pattern = vibration_pattern;
platform_data.timestamp = base::Time::FromJsTime(kNotificationTimestamp);
+ platform_data.renotify = true;
platform_data.silent = true;
platform_data.require_interaction = true;
platform_data.data = developer_data;
@@ -127,6 +130,7 @@ TEST(NotificationDataConversionsTest, ToWebNotificationData) {
EXPECT_EQ(vibration_pattern[i], web_data.vibrate[i]);
EXPECT_DOUBLE_EQ(kNotificationTimestamp, web_data.timestamp);
+ EXPECT_TRUE(web_data.renotify);
EXPECT_TRUE(web_data.silent);
EXPECT_TRUE(web_data.requireInteraction);
« no previous file with comments | « content/child/notifications/notification_data_conversions.cc ('k') | content/common/platform_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698