Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
index daa6663ef5ddc4b19109a3f4733fa2df18c92d09..9e5b459f1a6c702530e33dcac72c4edb1e073e33 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUIManager.java
@@ -421,6 +421,8 @@ public class NotificationUIManager {
* the platforms, whereas a default icon will be generated for invalid Bitmaps.
* @param vibrationPattern Vibration pattern following the Web Vibration syntax.
* @param timestamp The timestamp of the event for which the notification is being shown.
+ * @param renotify Whether the sound, vibration, and lights should be replayed if the
+ * notification is replacing another notification.
* @param silent Whether the default sound, vibration and lights should be suppressed.
* @param actionTitles Titles of actions to display alongside the notification.
* @see https://developer.android.com/reference/android/app/Notification.html
@@ -428,7 +430,8 @@ public class NotificationUIManager {
@CalledByNative
private void displayNotification(long persistentNotificationId, String origin, String profileId,
boolean incognito, String tag, String title, String body, Bitmap icon,
- int[] vibrationPattern, long timestamp, boolean silent, String[] actionTitles) {
+ int[] vibrationPattern, long timestamp, boolean renotify, boolean silent,
+ String[] actionTitles) {
Resources res = mAppContext.getResources();
// Record whether it's known whether notifications can be shown to the user at all.
@@ -465,6 +468,7 @@ public class NotificationUIManager {
.setDeleteIntent(closeIntent)
.setTicker(createTickerText(title, body))
.setTimestamp(timestamp)
+ .setRenotify(renotify)
.setOrigin(UrlUtilities.formatUrlForSecurityDisplay(
origin, false /* showScheme */));

Powered by Google App Engine
This is Rietveld 408576698