third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html - Issue 1656243002: Implementation of renotify flag for Notifications.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworker-notification-properties.html

Issue 1656243002: Implementation of renotify flag for Notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Code review comments and added LayoutTests interface listing files Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/public/common/platform_notification_data.h ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Property reflection in the "notificationclick" event a nd SWR.getNotifications().</title>	4 <title>Notifications: Property reflection in the "notificationclick" event a nd SWR.getNotifications().</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

(...skipping 21 matching lines...) Expand all Loading...
32 title: scope,	32 title: scope,

33 dir: 'rtl',	33 dir: 'rtl',

34 lang: 'nl-NL',	34 lang: 'nl-NL',

35 body: 'Hello, world!',	35 body: 'Hello, world!',

36 tag: 'tag',	36 tag: 'tag',

37 // FIXME: Relative URLs for the icon attribute currently get refle cted as	37 // FIXME: Relative URLs for the icon attribute currently get refle cted as

38 // an absolute URL, which should probably be the given relative UR L.	38 // an absolute URL, which should probably be the given relative UR L.

39 icon: 'https://example/icon.png',	39 icon: 'https://example/icon.png',

40 vibrate: [100, 200, 300],	40 vibrate: [100, 200, 300],

41 timestamp: 621046800000,	41 timestamp: 621046800000,

	42 renotify: false,
	Peter Beverloo 2016/02/03 11:34:38 false -> true "false" is the default value, so if false -> true "false" is the default value, so if something went wrong in the serialization step it would still end up being false. Testing for true requires the full data round-trip to work. harkness 2016/02/03 13:45:44 Done. Show quoted text On 2016/02/03 11:34:38, Peter Beverloo wrote: > false -> true > > "false" is the default value, so if something went wrong in the serialization > step it would still end up being false. Testing for true requires the full data > round-trip to work. Done.
42 silent: false,	43 silent: false,

43 requireInteraction: true,	44 requireInteraction: true,

44 data: [	45 data: [

45 { property: 'foobar',	46 { property: 'foobar',

46 string: '\uDFFF\u0000\uDBFF',	47 string: '\uDFFF\u0000\uDBFF',

47 scalar: true },	48 scalar: true },

48 12.15	49 12.15

49 ],	50 ],

50 actions: []	51 actions: []

51 };	52 };

(...skipping 57 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109	110

110 test.done();	111 test.done();

111 });	112 });

112 });	113 });

113 }).catch(unreached_rejection(test));	114 }).catch(unreached_rejection(test));

114	115

115 }, 'Clicking on a notification displayed by a Service Worker the notificat ionclick event.');	116 }, 'Clicking on a notification displayed by a Service Worker the notificat ionclick event.');

116 </script>	117 </script>

117 </body>	118 </body>

118 </html>	119 </html>

OLD	NEW