Implementation of renotify flag for Notifications.

third_party/WebKit/Source/modules/notifications/NotificationData.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/notifications/NotificationData.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "core/dom/ExecutionContext.h"
@@ skipping 20 matching lines @@
 } // namespace
 
 WebNotificationData createWebNotificationData(ExecutionContext* executionContext, const String& title, const NotificationOptions& options, ExceptionState& exceptionState)
 {
     // If silent is true, the notification must not have a vibration pattern.
     if (options.hasVibrate() && options.silent()) {
         exceptionState.throwTypeError("Silent notifications must not specify vibration patterns.");
         return WebNotificationData();
     }
 
+    // If renotify is true, the notification must have a tag.
+    if (options.renotify() && options.tag().isEmpty()) {
+        exceptionState.throwTypeError("Notifications which set the renotify flag must specify a valid tag.");

[Peter Beverloo, 2016/02/02 23:43:10]

a valid tag -> a non-empty tag

The only validity we care about it that it's non-zero in length, so we can be
specific here.

[harkness, 2016/02/03 11:24:28]

Done.

+        return WebNotificationData();
+    }
+
     WebNotificationData webData;
 
     webData.title = title;
     webData.direction = toDirectionEnumValue(options.dir());
     webData.lang = options.lang();
     webData.body = options.body();
     webData.tag = options.tag();
 
     KURL iconUrl;
 
     // TODO(peter): Apply the appropriate CORS checks on the |iconUrl|.
     if (options.hasIcon() && !options.icon().isEmpty()) {
         iconUrl = executionContext->completeURL(options.icon());
         if (!iconUrl.isValid())
             iconUrl = KURL();
     }
 
     webData.icon = iconUrl;
     webData.vibrate = NavigatorVibration::sanitizeVibrationPattern(options.vibrate());
     webData.timestamp = options.hasTimestamp() ? static_cast<double>(options.timestamp()) : WTF::currentTimeMS();
     webData.silent = options.silent();
+    webData.renotify = options.renotify();
     webData.requireInteraction = options.requireInteraction();
 
     if (options.hasData()) {
         RefPtr<SerializedScriptValue> serializedScriptValue = SerializedScriptValueFactory::instance().create(options.data().isolate(), options.data(), nullptr, exceptionState);
         if (exceptionState.hadException())
             return WebNotificationData();
 
         Vector<char> serializedData;
         serializedScriptValue->toWireBytes(serializedData);
 
@@ skipping 13 matching lines @@
 
         actions.append(webAction);
     }
 
     webData.actions = actions;
 
     return webData;
 }
 
 } // namespace blink