Implementation of renotify flag for Notifications.

content/child/notifications/notification_data_conversions_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/notifications/notification_data_conversions.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/macros.h"
@@ skipping 24 matching lines @@
   blink::WebNotificationData web_data;
   web_data.title = blink::WebString::fromUTF8(kNotificationTitle);
   web_data.direction = blink::WebNotificationData::DirectionLeftToRight;
   web_data.lang = blink::WebString::fromUTF8(kNotificationLang);
   web_data.body = blink::WebString::fromUTF8(kNotificationBody);
   web_data.tag = blink::WebString::fromUTF8(kNotificationTag);
   web_data.icon = blink::WebURL(GURL(kNotificationIconUrl));
   web_data.vibrate = blink::WebVector<int>(
       kNotificationVibrationPattern, arraysize(kNotificationVibrationPattern));
   web_data.timestamp = kNotificationTimestamp;
+  web_data.renotify = true;
   web_data.silent = true;
   web_data.requireInteraction = true;
   web_data.data =
       blink::WebVector<char>(kNotificationData, arraysize(kNotificationData));
 
   web_data.actions =
       blink::WebVector<blink::WebNotificationAction>(static_cast<size_t>(2));
   web_data.actions[0].action = blink::WebString::fromUTF8(kAction1Name);
   web_data.actions[0].title = blink::WebString::fromUTF8(kAction1Title);
   web_data.actions[1].action = blink::WebString::fromUTF8(kAction2Name);
   web_data.actions[1].title = blink::WebString::fromUTF8(kAction2Title);
 
   PlatformNotificationData platform_data = ToPlatformNotificationData(web_data);
   EXPECT_EQ(base::ASCIIToUTF16(kNotificationTitle), platform_data.title);
   EXPECT_EQ(PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT,
             platform_data.direction);
   EXPECT_EQ(kNotificationLang, platform_data.lang);
   EXPECT_EQ(base::ASCIIToUTF16(kNotificationBody), platform_data.body);
   EXPECT_EQ(kNotificationTag, platform_data.tag);
   EXPECT_EQ(kNotificationIconUrl, platform_data.icon.spec());
+  EXPECT_TRUE(platform_data.renotify);
   EXPECT_TRUE(platform_data.silent);
   EXPECT_TRUE(platform_data.require_interaction);
 
   EXPECT_THAT(platform_data.vibration_pattern,
               testing::ElementsAreArray(kNotificationVibrationPattern));
 
   EXPECT_DOUBLE_EQ(kNotificationTimestamp, platform_data.timestamp.ToJsTime());
   ASSERT_EQ(web_data.data.size(), platform_data.data.size());
   for (size_t i = 0; i < web_data.data.size(); ++i)
     EXPECT_EQ(web_data.data[i], platform_data.data[i]);
   ASSERT_EQ(web_data.actions.size(), platform_data.actions.size());
   EXPECT_EQ(kAction1Name, platform_data.actions[0].action);
   EXPECT_EQ(base::ASCIIToUTF16(kAction1Title), platform_data.actions[0].title);
   EXPECT_EQ(kAction2Name, platform_data.actions[1].action);
   EXPECT_EQ(base::ASCIIToUTF16(kAction2Title), platform_data.actions[1].title);
 }
 
 TEST(NotificationDataConversionsTest, ToWebNotificationData) {

[Michael van Ouwerkerk, 2016/02/08 17:18:22]

Please also add coverage for this case.

[harkness, 2016/02/09 11:06:30]

Done.

   std::vector<int> vibration_pattern(
       kNotificationVibrationPattern,
       kNotificationVibrationPattern + arraysize(kNotificationVibrationPattern));
 
   std::vector<char> developer_data(
       kNotificationData, kNotificationData + arraysize(kNotificationData));
 
   PlatformNotificationData platform_data;
   platform_data.title = base::ASCIIToUTF16(kNotificationTitle);
   platform_data.direction = PlatformNotificationData::DIRECTION_LEFT_TO_RIGHT;
@@ skipping 102 matching lines @@
     blink::WebNotificationData web_data;
     web_data.timestamp = 0;
 
     blink::WebNotificationData copied_data =
         ToWebNotificationData(ToPlatformNotificationData(web_data));
     EXPECT_EQ(web_data.timestamp, copied_data.timestamp);
   }
 }
 
 }  // namespace content