Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1656223002: [turbofan] Optimize dynamic variable load of global constant. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Optimize dynamic variable load of global constant. Don't insert a JSLoadGlobal node in the fast case of a dynamic variable load if the target is a global constant. R=jarin@chromium.org Committed: https://crrev.com/c4d366fb0c07acfbc30ada9103fa0ca24b50a143 Cr-Commit-Position: refs/heads/master@{#33657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-02 07:56:41 UTC) #1
Benedikt Meurer
Hey Jaro, Same optimization as applied to the static load case. Please take a look. ...
4 years, 10 months ago (2016-02-02 07:57:35 UTC) #2
Jarin
lgtm
4 years, 10 months ago (2016-02-02 07:58:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656223002/1
4 years, 10 months ago (2016-02-02 07:59:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 08:23:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 08:24:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4d366fb0c07acfbc30ada9103fa0ca24b50a143
Cr-Commit-Position: refs/heads/master@{#33657}

Powered by Google App Engine
This is Rietveld 408576698