Neutering API for v8::ArrayBuffer

Neutering API for v8::ArrayBuffer

R=svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15006

[Dmitry Lomov (no reviews), 2013-06-07 11:26:31]

API for neutering ArrayBuffer.

svenpanne: please review
mstarzinger,hpayer: FYI (this is the reason for ArrayBuffer weak lists etc)

[Sven Panne, 2013-06-07 12:21:08]

LGTM with a nit.

https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:2668: int byteOffset,
Using size_t instead of int for offset/length is cleaner and even gets rid of
the casts below.

[Dmitry Lomov (no reviews), 2013-06-07 14:57:09]

https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):

https://codereview.chromium.org/16562005/diff/9001/test/cctest/test-api.cc#ne...
test/cctest/test-api.cc:2668: int byteOffset,
On 2013/06/07 12:21:08, Sven Panne wrote:
> Using size_t instead of int for offset/length is cleaner and even gets rid of
> the casts below.
No it does not get rid of casts - compiler gets confused about what overload for
CheckEqualsHelper to use:
./test/cctest/test-api.cc:2672:3: error: call to 'CheckEqualsHelper' is
ambiguous
  CHECK_EQ(length, ta->Length());
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'll land as is, but maybe we should consider size_t overload for
CheckEqualsHelper or smth.
Yell if you don't like it.

[Dmitry Lomov (no reviews), 2013-06-07 15:02:29]

Committed patchset #1 manually as r15006 (presubmit successful).