Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 16562003: Allow smis for singleton types (Closed)

Created:
7 years, 6 months ago by rossberg
Modified:
7 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Allow smis for singleton types To that end, introduce a generic Box struct. R=danno@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14987

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -19 lines) Patch
M include/v8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/objects.h View 5 chunks +24 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/types.h View 1 3 chunks +8 lines, -9 lines 0 comments Download
M src/types.cc View 1 3 chunks +12 lines, -4 lines 0 comments Download
M test/cctest/test-types.cc View 8 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
7 years, 6 months ago (2013-06-06 14:56:47 UTC) #1
danno
lgtm with a comment https://codereview.chromium.org/16562003/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/16562003/diff/1/src/types.h#newcode90 src/types.h:90: typedef v8::internal::Object Value; As discussed, ...
7 years, 6 months ago (2013-06-06 15:36:03 UTC) #2
rossberg
https://codereview.chromium.org/16562003/diff/1/src/types.h File src/types.h (right): https://codereview.chromium.org/16562003/diff/1/src/types.h#newcode90 src/types.h:90: typedef v8::internal::Object Value; On 2013/06/06 15:36:03, danno wrote: > ...
7 years, 6 months ago (2013-06-06 15:38:35 UTC) #3
rossberg
7 years, 6 months ago (2013-06-06 15:40:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14987 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698