Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1656133002: Cleanup: Remove various unused functions related to loading nexes over SRPC (Closed)

Created:
4 years, 10 months ago by Mark Seaborn
Modified:
4 years, 10 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Cleanup: Remove various unused functions related to loading nexes over SRPC Remove the following: NaClCreateServiceSocket() NaClSecureCommandChannel() NaClSetUpBootstrapChannel() NaClWaitForLoadModuleCommand() NaClWaitForStartModuleCommand() NaClBlockIfCommandChannelExists() BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=3864 TEST=trybots Committed: https://chromium.googlesource.com/native_client/src/native_client/+/027e3e7e81d51ecf07eef06788f052b18e4f9278

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -242 lines) Patch
M src/trusted/service_runtime/nacl_secure_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.h View 2 chunks +0 lines, -30 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 3 chunks +0 lines, -193 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr_test.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mark Seaborn
4 years, 10 months ago (2016-02-02 01:19:09 UTC) #3
Roland McGrath
lgtm
4 years, 10 months ago (2016-02-03 19:47:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656133002/1
4 years, 10 months ago (2016-02-03 19:54:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: nacl-presubmit on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-presubmit/builds/541)
4 years, 10 months ago (2016-02-03 19:59:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656133002/1
4 years, 10 months ago (2016-02-03 21:47:52 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:08:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/027e3e7e8...

Powered by Google App Engine
This is Rietveld 408576698