Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1656123002: Moves accelerator registration to WindowManager (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves accelerator registration to WindowManager And makes the desktop_wm register accelerators on all roots. BUG=553619 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/ffa8df2c1d4469598b5ea76db51b36857b10c00c Cr-Commit-Position: refs/heads/master@{#372898}

Patch Set 1 #

Patch Set 2 : Fix multiple registration #

Patch Set 3 : fix mandoline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -109 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_manager_delegate.h View 3 chunks +12 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 2 chunks +13 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_tree_host.mojom View 3 chunks +1 line, -13 lines 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 2 chunks +2 lines, -4 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 2 chunks +1 line, -13 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 1 2 4 chunks +12 lines, -4 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 2 5 chunks +53 lines, -21 lines 0 comments Download
M mash/wm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/wm/accelerator_registrar_impl.h View 1 3 chunks +22 lines, -11 lines 0 comments Download
M mash/wm/accelerator_registrar_impl.cc View 1 5 chunks +75 lines, -18 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M mash/wm/root_window_controller.cc View 2 chunks +13 lines, -13 lines 0 comments Download
A mash/wm/root_windows_observer.h View 1 chunk +26 lines, -0 lines 0 comments Download
M mash/wm/window_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mash/wm/window_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.h View 5 chunks +13 lines, -0 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 6 chunks +33 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 10 months ago (2016-02-02 00:33:36 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 10 months ago (2016-02-02 00:56:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1656123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1656123002/40001
4 years, 10 months ago (2016-02-02 04:38:39 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-02 05:47:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 05:49:07 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ffa8df2c1d4469598b5ea76db51b36857b10c00c
Cr-Commit-Position: refs/heads/master@{#372898}

Powered by Google App Engine
This is Rietveld 408576698