Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1967)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1656033004: Do not navigate "other" windows to about:blank in OnReset. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@triage-of-layout-test-failures-1
Patch Set: Rebasing the expectations file. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 1f6b85598893b3a87f2fc6634b81e0c3d7dccf36..0a2bebaee559eb465a070021987fd8fc8c3f2052 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -170,26 +170,6 @@ class ProxyToRenderViewVisitor : public RenderViewVisitor {
DISALLOW_COPY_AND_ASSIGN(ProxyToRenderViewVisitor);
};
-class NavigateAwayVisitor : public RenderViewVisitor {
- public:
- explicit NavigateAwayVisitor(RenderView* main_render_view)
- : main_render_view_(main_render_view) {}
- ~NavigateAwayVisitor() override {}
-
- bool Visit(RenderView* render_view) override {
- if (render_view == main_render_view_)
- return true;
- render_view->GetWebView()->mainFrame()->loadRequest(
- WebURLRequest(GURL(url::kAboutBlankURL)));
- return true;
- }
-
- private:
- RenderView* main_render_view_;
-
- DISALLOW_COPY_AND_ASSIGN(NavigateAwayVisitor);
-};
-
class UseSynchronousResizeModeVisitor : public RenderViewVisitor {
public:
explicit UseSynchronousResizeModeVisitor(bool enable) : enable_(enable) {}
@@ -646,8 +626,6 @@ void BlinkTestRunner::TestFinished() {
}
void BlinkTestRunner::CloseRemainingWindows() {
- NavigateAwayVisitor visitor(render_view());
- RenderView::ForEach(&visitor);
Send(new ShellViewHostMsg_CloseRemainingWindows(routing_id()));
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698