Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1656023002: Fix skip_unimplemented for filetype=obj in ARM. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix skip_unimplemented for filetype=obj in ARM. Fixes generation of emit text fixup code in integrated ARM assembler to properly reset the text fixup flag when skipping unimplemented instructions. Also fixes broken assertion for the "vmul" instruction. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=82975ba6fc68c16f10bb437d95d9c0d1859b141e

Patch Set 1 #

Patch Set 2 : Fix mangled code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M src/IceAssembler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceAssembler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInstARM32.cpp View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 10 months ago (2016-02-01 21:01:19 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-01 23:39:51 UTC) #4
Karl
4 years, 10 months ago (2016-02-02 18:17:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
82975ba6fc68c16f10bb437d95d9c0d1859b141e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698