Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1655933002: Update the dng_sdk version. The new version handles the posix_memalign() better (Closed)

Created:
4 years, 10 months ago by yujieqin
Modified:
4 years, 10 months ago
Reviewers:
msarett, scroggo
CC:
reviews_skia.org, adaubert
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update the dng_sdk version. The new version handles the posix_memalign() better Remove the '-DNO_POSIX_MEMALIGN' With this change, most new Android (API>=17) should be able to use posix_memalign() BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1655933002 Committed: https://skia.googlesource.com/skia/+/8f9447cf606398475f19c5608d4636433c389dcc

Patch Set 1 #

Patch Set 2 : Use newer version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/dng_sdk.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
yujieqin
4 years, 10 months ago (2016-02-02 08:27:25 UTC) #5
msarett
lgtm Might want to wait for the Nexus 5 bot to get straightened out before ...
4 years, 10 months ago (2016-02-02 13:54:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655933002/20001
4 years, 10 months ago (2016-02-03 08:29:17 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8f9447cf606398475f19c5608d4636433c389dcc
4 years, 10 months ago (2016-02-03 08:50:16 UTC) #10
jcgregorio
On 2016/02/03 at 08:50:16, commit-bot wrote: > Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/8f9447cf606398475f19c5608d4636433c389dcc This CL ...
4 years, 10 months ago (2016-02-03 16:50:55 UTC) #11
jcgregorio
4 years, 10 months ago (2016-02-03 16:58:11 UTC) #12
Message was sent while issue was closed.
On 2016/02/03 at 16:50:55, jcgregorio wrote:
> On 2016/02/03 at 08:50:16, commit-bot wrote:
> > Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8f9447cf606398475f19c5608d4636433c389dcc
> 
> This CL seems to have triggered an ASAN issue (sorry for not catching it
earlier, it was masked by an unrelated build exception in the same run):
> 
>
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX...
>
https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX...
> 
> 
>   Running
complexclip_blur_tiled->pic-8888../../../src/core/SkScan_AntiPath.cpp:706:41:
runtime error: left shift of negative value -15
>   SUMMARY: AddressSanitizer: undefined-behavior
../../../src/core/SkScan_AntiPath.cpp:706:41
> 
> Is it possible this change is the cause?

Never mind, I was misreading the previous builds.

Powered by Google App Engine
This is Rietveld 408576698