Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 165593002: Revert of Turn on icu_use_data_file_flag on CrOS (Closed)

Created:
6 years, 10 months ago by jungshik at Google
Modified:
6 years, 10 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, vapier
Visibility:
Public.

Description

Revert of Turn on icu_use_data_file_flag on CrOS (https://codereview.chromium.org/163793004/) Reason for revert: https://chromium-review.googlesource.com/#/c/185937/ has to go in first. Original issue's description: > Turn on icu_use_data_file_flag on CrOS > > See also https://chromium-review.googlesource.com/#/c/185937/ > > The switch has to be turned on in two places (chromeos-chrome.ebuild and > build/common.gypi). One or the other can get landed separately, though. > > BUG=72633 > TEST=net_unittests:*IDN* and base_unittests:*String* > TBR=mark > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251213 TBR=mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=72633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251214

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
Created Revert of Turn on icu_use_data_file_flag on CrOS
6 years, 10 months ago (2014-02-14 00:55:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/165593002/1
6 years, 10 months ago (2014-02-14 00:56:46 UTC) #2
commit-bot: I haz the power
Change committed as 251214
6 years, 10 months ago (2014-02-14 00:58:51 UTC) #3
jungshik at Google
A revert of this CL has been created in https://codereview.chromium.org/164333003/ by jshin@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-14 01:13:56 UTC) #4
Mark Mentovai
6 years, 10 months ago (2014-02-14 02:06:14 UTC) #5
Message was sent while issue was closed.
LGTM (subsequently reverted in https://codereview.chromium.org/164333003/
r251220)

Powered by Google App Engine
This is Rietveld 408576698