native_client_sdk/src/build_tools/build_projects.py - Issue 1655873003: [NaCl SDK] Cleanup references to old newlib toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/build_projects.py

Issue 1655873003: [NaCl SDK] Cleanup references to old newlib toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_pepper_50

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/README.Makefiles ('k') | native_client_sdk/src/build_tools/build_sdk.py » ('j') | native_client_sdk/src/doc/devguide/devcycle/building.rst » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/build_tools/build_projects.py

diff --git a/native_client_sdk/src/build_tools/build_projects.py b/native_client_sdk/src/build_tools/build_projects.py

index 1646d6be8b540c4b7fe5524b90f1887ac29d5d34..fe168cdc1c76645cd65865349efaa06e405fbf5c 100755

--- a/native_client_sdk/src/build_tools/build_projects.py

+++ b/native_client_sdk/src/build_tools/build_projects.py

@@ -30,7 +30,6 @@ LIB_DICT = {

'win': ['x86_32']

}

VALID_TOOLCHAINS = [

- 'newlib',

'clang-newlib',

'glibc',

'pnacl',

@@ -291,9 +290,9 @@ def main(args):

if not options.toolchain:

# Order matters here: the default toolchain for an example's Makefile will

# be the first toolchain in this list that is available in the example.

- # e.g. If an example supports newlib and glibc, then the default will be

- # newlib.

- options.toolchain = ['pnacl', 'newlib', 'glibc', 'host', 'clang-newlib']

+ # e.g. If an example supports clang-newlib and glibc, then the default will

+ # be clang-newlib.

+ options.toolchain = ['pnacl', 'clang-newlib', 'glibc', 'host']

if 'host' in options.toolchain:

options.toolchain.remove('host')