native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst - Issue 1655873003: [NaCl SDK] Cleanup references to old newlib toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst

Issue 1655873003: [NaCl SDK] Cleanup references to old newlib toolchain (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add_pepper_50

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst ('k') | native_client_sdk/src/doc/doxygen/generate_docs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst

diff --git a/native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst b/native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst

index 6338b19fd15b184f52536fdf31f4cfef9b956f95..af68396d9b252b8ac63c0b0ff3d7bb5c7fb6bd85 100644

--- a/native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst

+++ b/native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst

@@ -52,7 +52,7 @@ Glibc NaCl) and two configurations (Debug, Release).

.. naclcode::

- VALID_TOOLCHAINS := pnacl newlib glibc

+ VALID_TOOLCHAINS := pnacl clang-newlib glibc

NACL_SDK_ROOT ?= $(abspath $(CURDIR)/../..)

include $(NACL_SDK_ROOT)/tools/common.mk

@@ -88,11 +88,12 @@ when you begin your project and never change it. Please see the

:ref:`Toolchains section of the Native Client overview <toolchains>` for more

information.

-For this example, we support the ``pnacl``, ``newlib`` and ``glibc`` toolchains.

+For this example, we support the ``pnacl``, ``clang-newlib`` and ``glibc``

+toolchains.

.. naclcode::

- VALID_TOOLCHAINS := pnacl newlib glibc

+ VALID_TOOLCHAINS := pnacl clang-newlib glibc

Next, as a convenience, we specify where to find ``NACL_SDK_ROOT``. Because

this example is located in ``pepper_$(VERSION)/getting_started/part2``, the

@@ -290,7 +291,7 @@ configurations, and path to the ``.nmf`` file:

.. naclcode::

<body data-name="part2"

- data-tools="newlib glibc pnacl"

+ data-tools="clang-newlib glibc pnacl"

data-configs="Debug Release"

data-path="{tc}/{config}">

...