Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1655873003: [NaCl SDK] Cleanup references to old newlib toolchain (Closed)

Created:
4 years, 10 months ago by Sam Clegg
Modified:
4 years, 10 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_pepper_50
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Cleanup references to old newlib toolchain - remove references from the docs - don't build newlib SDK componenes - remove newlib as a valid toolchain in the build system - remove use_sysroot=1 setting (this is now the default) - remove old/unused dsc2gyp.py script - regenerate docs CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk Committed: https://crrev.com/c993138c3d8ad664955d8a328011984746bffff0 Cr-Commit-Position: refs/heads/master@{#373024}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -695 lines) Patch
M native_client_sdk/doc_generated/c-api.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/c-api-beta.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/c-api-dev.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/cpp-api.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/cpp-api-beta.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/cpp-api-dev.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/building.html View 1 2 3 4 5 6 chunks +26 lines, -23 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/devcycle/dynamic-loading.html View 1 2 3 3 chunks +15 lines, -12 lines 0 comments Download
M native_client_sdk/doc_generated/devguide/tutorial/tutorial-part2.html View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M native_client_sdk/doc_generated/pepper_beta/index.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/pepper_dev/index.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/pepper_stable/index.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/examples.html View 1 2 3 3 chunks +33 lines, -33 lines 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M native_client_sdk/doc_generated/sitemap.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M native_client_sdk/src/BUILDING.rst View 4 chunks +9 lines, -9 lines 0 comments Download
M native_client_sdk/src/README.Makefiles View 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/build_projects.py View 2 chunks +3 lines, -4 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 7 chunks +14 lines, -45 lines 0 comments Download
D native_client_sdk/src/build_tools/dsc2gyp.py View 1 chunk +0 lines, -378 lines 0 comments Download
D native_client_sdk/src/build_tools/nacl.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
M native_client_sdk/src/build_tools/parse_dsc.py View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +0 lines, -1 line 0 comments Download
M native_client_sdk/src/doc/Makefile View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/doc/c-api.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/c-api-beta.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/c-api-dev.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/cpp-api.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/cpp-api-beta.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/cpp-api-dev.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/building.rst View 1 2 3 4 5 7 chunks +26 lines, -25 lines 0 comments Download
M native_client_sdk/src/doc/devguide/devcycle/dynamic-loading.rst View 3 chunks +7 lines, -7 lines 0 comments Download
M native_client_sdk/src/doc/devguide/tutorial/tutorial-part2.rst View 3 chunks +5 lines, -4 lines 0 comments Download
M native_client_sdk/src/doc/doxygen/generate_docs.py View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M native_client_sdk/src/doc/pepper_beta/index.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/pepper_dev/index.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/pepper_stable/index.rst View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/doc/sdk/examples.rst View 3 chunks +33 lines, -33 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 chunk +6 lines, -3 lines 0 comments Download
M native_client_sdk/src/getting_started/part2/README View 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/getting_started/part2/index.html View 1 chunk +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/cube/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/earth/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/life/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/src/voronoi/Makefile View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/tools/compiler-wrapper.py View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Sam Clegg
4 years, 10 months ago (2016-02-02 02:49:23 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655873003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655873003/80001
4 years, 10 months ago (2016-02-02 04:11:50 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 06:09:25 UTC) #9
binji
lgtm https://codereview.chromium.org/1655873003/diff/80001/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/1655873003/diff/80001/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode55 native_client_sdk/src/doc/devguide/devcycle/building.rst:55: The PNaCl SDK uses the newlib_ C library. ...
4 years, 10 months ago (2016-02-02 18:22:05 UTC) #10
Sam Clegg
https://codereview.chromium.org/1655873003/diff/80001/native_client_sdk/src/doc/devguide/devcycle/building.rst File native_client_sdk/src/doc/devguide/devcycle/building.rst (right): https://codereview.chromium.org/1655873003/diff/80001/native_client_sdk/src/doc/devguide/devcycle/building.rst#newcode55 native_client_sdk/src/doc/devguide/devcycle/building.rst:55: The PNaCl SDK uses the newlib_ C library. The ...
4 years, 10 months ago (2016-02-02 18:31:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655873003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655873003/100001
4 years, 10 months ago (2016-02-02 18:32:48 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-02 20:45:33 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 20:46:22 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c993138c3d8ad664955d8a328011984746bffff0
Cr-Commit-Position: refs/heads/master@{#373024}

Powered by Google App Engine
This is Rietveld 408576698