Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 1655853002: [regexp] add fuzzer support for regexp parser and compiler. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] add fuzzer support for regexp parser and compiler. R=jochen@chromium.org BUG=chromium:577261 LOG=N Committed: https://crrev.com/9f5dca8faa05d70b89ad9b795b0feed1513615aa Cr-Commit-Position: refs/heads/master@{#33640}

Patch Set 1 #

Patch Set 2 : fix swarming #

Total comments: 1

Patch Set 3 : also test two-byte #

Patch Set 4 : reduce test cases #

Patch Set 5 : fix fuzzer.isolate #

Total comments: 1

Patch Set 6 : fix fuzzer.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -1 line) Patch
M BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 1 2 3 4 5 2 chunks +27 lines, -0 lines 0 comments Download
M test/fuzzer/fuzzer.isolate View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A test/fuzzer/regexp.cc View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A test/fuzzer/regexp/test00 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test01 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test02 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test03 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test04 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test05 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test06 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test07 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test08 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test09 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test10 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test11 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test12 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test13 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test14 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test15 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test16 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test17 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test18 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test19 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test20 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test21 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test22 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test23 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A test/fuzzer/regexp/test24 View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzzer/testcfg.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 42 (21 generated)
Yang
4 years, 10 months ago (2016-02-01 11:57:51 UTC) #1
Yang
On 2016/02/01 11:57:51, Yang wrote: The test cases are taken from test/cctest/test-regexp.cc
4 years, 10 months ago (2016-02-01 11:59:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/1
4 years, 10 months ago (2016-02-01 12:00:22 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2016-02-01 12:03:06 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14791)
4 years, 10 months ago (2016-02-01 12:06:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/20001
4 years, 10 months ago (2016-02-01 12:15:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/40001
4 years, 10 months ago (2016-02-01 12:37:02 UTC) #15
Michael Achenbach
I unchecked for now. Not liking this output: https://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/builds/2028/steps/Check/logs/stdio Especially from an infra pov. I'll ...
4 years, 10 months ago (2016-02-01 12:49:46 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/60001
4 years, 10 months ago (2016-02-01 12:51:27 UTC) #19
Michael Achenbach
https://codereview.chromium.org/1655853002/diff/20001/test/fuzzer/fuzzer.isolate File test/fuzzer/fuzzer.isolate (right): https://codereview.chromium.org/1655853002/diff/20001/test/fuzzer/fuzzer.isolate#newcode8 test/fuzzer/fuzzer.isolate:8: '<(PRODUCT_DIR)/parser_fuzzer<(EXECUTABLE_SUFFIX)', To fix the problems of this patch you ...
4 years, 10 months ago (2016-02-01 12:51:56 UTC) #21
Yang
On 2016/02/01 12:51:56, Michael Achenbach wrote: > https://codereview.chromium.org/1655853002/diff/20001/test/fuzzer/fuzzer.isolate > File test/fuzzer/fuzzer.isolate (right): > > https://codereview.chromium.org/1655853002/diff/20001/test/fuzzer/fuzzer.isolate#newcode8 ...
4 years, 10 months ago (2016-02-01 12:53:10 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/80001
4 years, 10 months ago (2016-02-01 12:53:18 UTC) #26
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/12569)
4 years, 10 months ago (2016-02-01 13:00:55 UTC) #28
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1655853002/diff/80001/test/fuzzer/fuzzer.gyp File test/fuzzer/fuzzer.gyp (right): https://codereview.chromium.org/1655853002/diff/80001/test/fuzzer/fuzzer.gyp#newcode94 test/fuzzer/fuzzer.gyp:94: 'parser_fuzzer', probably also need to add regexp_fuzzer here?
4 years, 10 months ago (2016-02-01 13:11:03 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/100001
4 years, 10 months ago (2016-02-01 13:13:05 UTC) #31
Yang
On 2016/02/01 13:11:03, jochen wrote: > https://codereview.chromium.org/1655853002/diff/80001/test/fuzzer/fuzzer.gyp > File test/fuzzer/fuzzer.gyp (right): > > https://codereview.chromium.org/1655853002/diff/80001/test/fuzzer/fuzzer.gyp#newcode94 > ...
4 years, 10 months ago (2016-02-01 13:13:10 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655853002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655853002/100001
4 years, 10 months ago (2016-02-01 13:54:21 UTC) #36
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 10 months ago (2016-02-01 14:00:20 UTC) #38
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/9f5dca8faa05d70b89ad9b795b0feed1513615aa Cr-Commit-Position: refs/heads/master@{#33640}
4 years, 10 months ago (2016-02-01 14:00:46 UTC) #40
kcc2
On 2016/02/01 14:00:46, commit-bot: I haz the power wrote: > Patchset 6 (id:??) landed as ...
4 years, 10 months ago (2016-02-06 04:00:54 UTC) #41
kcc2
4 years, 10 months ago (2016-02-06 04:00:57 UTC) #42
Message was sent while issue was closed.
On 2016/02/01 14:00:46, commit-bot: I haz the power wrote:
> Patchset 6 (id:??) landed as
> https://crrev.com/9f5dca8faa05d70b89ad9b795b0feed1513615aa
> Cr-Commit-Position: refs/heads/master@{#33640}

btw, the fuzzer is *very* slow, about 2 exec/s

Powered by Google App Engine
This is Rietveld 408576698