Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/interface-descriptors.h

Issue 1655833002: Remove the template magic from types.(h|cc), remove types-inl.h. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Undo whitespace change Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/ic-state.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interface-descriptors.h
diff --git a/src/interface-descriptors.h b/src/interface-descriptors.h
index 8a43ec13a66e47aa14aa0ce6535d0bbc8895979c..1c71d0f94005d5121d68aa8bc6afd6910e0de56f 100644
--- a/src/interface-descriptors.h
+++ b/src/interface-descriptors.h
@@ -89,7 +89,7 @@ class CallInterfaceDescriptorData {
// A copy of the passed in registers and param_representations is made
// and owned by the CallInterfaceDescriptorData.
- void InitializePlatformIndependent(Type::FunctionType* function_type) {
+ void InitializePlatformIndependent(FunctionType* function_type) {
function_type_ = function_type;
}
@@ -112,7 +112,7 @@ class CallInterfaceDescriptorData {
return platform_specific_descriptor_;
}
- Type::FunctionType* function_type() const { return function_type_; }
+ FunctionType* function_type() const { return function_type_; }
private:
int register_param_count_;
@@ -124,7 +124,7 @@ class CallInterfaceDescriptorData {
base::SmartArrayPointer<Register> register_params_;
// Specifies types for parameters and return
- Type::FunctionType* function_type_;
+ FunctionType* function_type_;
PlatformInterfaceDescriptor* platform_specific_descriptor_;
@@ -175,21 +175,19 @@ class CallInterfaceDescriptor {
return data()->platform_specific_descriptor();
}
- Type::FunctionType* GetFunctionType() const {
- return data()->function_type();
- }
+ FunctionType* GetFunctionType() const { return data()->function_type(); }
static const Register ContextRegister();
const char* DebugName(Isolate* isolate) const;
- static Type::FunctionType* BuildDefaultFunctionType(Isolate* isolate,
- int paramater_count);
+ static FunctionType* BuildDefaultFunctionType(Isolate* isolate,
+ int paramater_count);
protected:
const CallInterfaceDescriptorData* data() const { return data_; }
- virtual Type::FunctionType* BuildCallInterfaceDescriptorFunctionType(
+ virtual FunctionType* BuildCallInterfaceDescriptorFunctionType(
Isolate* isolate, int register_param_count) {
return BuildDefaultFunctionType(isolate, register_param_count);
}
@@ -202,9 +200,8 @@ class CallInterfaceDescriptor {
if (!data()->IsInitialized()) {
CallInterfaceDescriptorData* d = isolate->call_descriptor_data(key);
InitializePlatformSpecific(d);
- Type::FunctionType* function_type =
- BuildCallInterfaceDescriptorFunctionType(isolate,
- d->register_param_count());
+ FunctionType* function_type = BuildCallInterfaceDescriptorFunctionType(
+ isolate, d->register_param_count());
d->InitializePlatformIndependent(function_type);
}
}
@@ -226,16 +223,14 @@ class CallInterfaceDescriptor {
public: \
static inline CallDescriptors::Key key();
-
#define DECLARE_DESCRIPTOR_WITH_CUSTOM_FUNCTION_TYPE(name, base) \
DECLARE_DESCRIPTOR(name, base) \
protected: \
- Type::FunctionType* BuildCallInterfaceDescriptorFunctionType( \
+ FunctionType* BuildCallInterfaceDescriptorFunctionType( \
Isolate* isolate, int register_param_count) override; \
\
public:
-
class VoidDescriptor : public CallInterfaceDescriptor {
public:
DECLARE_DESCRIPTOR(VoidDescriptor, CallInterfaceDescriptor)
« no previous file with comments | « src/ic/ic-state.cc ('k') | src/interface-descriptors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698