Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1655823002: Fix S32_D32_constX_shaderproc assert (Closed)

Created:
4 years, 10 months ago by f(malita)
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org, jcgregorio
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix S32_D32_constX_shaderproc assert After https://crrev.com/1642273002, fFilterOneY includes a rounding bias which is not accounted for in the debug-mode S32_D32_constX_shaderproc check. Update the S32_D32_constX_shaderproc assert to use the (biased) SkBitmapProcStateAutoMapper utility. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1655823002 R=reed@google.com BUG=skia:4874 Committed: https://skia.googlesource.com/skia/+/d2a4271c753546c59607ad335807f5950ec96cc5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
M src/core/SkBitmapProcState.cpp View 1 2 chunks +20 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
f(malita)
Verified that CT DM 10k passes with this: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_DM_10k_SKPs-Trybot/builds/4
4 years, 10 months ago (2016-02-01 12:34:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655823002/20001
4 years, 10 months ago (2016-02-01 12:34:39 UTC) #6
reed1
lgtm
4 years, 10 months ago (2016-02-01 12:39:03 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-01 12:45:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655823002/20001
4 years, 10 months ago (2016-02-01 12:48:01 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 12:48:42 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d2a4271c753546c59607ad335807f5950ec96cc5

Powered by Google App Engine
This is Rietveld 408576698