Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1655773002: Revert of Remove all descendant views from AXAuraObjCache when a view is removed. (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni, David Tseng, sky
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove all descendant views from AXAuraObjCache when a view is removed. (patchset #3 id:40001 of https://codereview.chromium.org/1629403004/ ) Reason for revert: fails on lsan bot: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/9196/steps/views_unittests/logs/stdio Original issue's description: > Remove all descendant views from AXAuraObjCache when a view is removed. > > BUG=581426 > > Committed: https://crrev.com/6c4af2f35251aad93cb80f3cfdd4c38d3a616719 > Cr-Commit-Position: refs/heads/master@{#372453} TBR=dtseng@chromium.org,sky@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581426 Committed: https://crrev.com/887807308ddbcae3d56962a0abcc79ef01d51275 Cr-Commit-Position: refs/heads/master@{#372631}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -70 lines) Patch
M ui/views/accessibility/ax_aura_obj_cache.h View 2 chunks +5 lines, -6 lines 0 comments Download
M ui/views/accessibility/ax_aura_obj_cache.cc View 2 chunks +7 lines, -5 lines 0 comments Download
D ui/views/accessibility/ax_aura_obj_cache_unittest.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M ui/views/accessibility/ax_widget_obj_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
Created Revert of Remove all descendant views from AXAuraObjCache when a view is removed.
4 years, 10 months ago (2016-02-01 09:32:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655773002/1
4 years, 10 months ago (2016-02-01 09:32:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655773002/1
4 years, 10 months ago (2016-02-01 10:03:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 10:16:53 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:18:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/887807308ddbcae3d56962a0abcc79ef01d51275
Cr-Commit-Position: refs/heads/master@{#372631}

Powered by Google App Engine
This is Rietveld 408576698