Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1655743002: [regexp] fix indentation and variable shadowing. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
brucedawson
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix indentation and variable shadowing. TBR=brucedawson@chromium.org Committed: https://crrev.com/a6aef2373cc41ca7d62e1bd02cda4cef782aff90 Cr-Commit-Position: refs/heads/master@{#33628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M src/regexp/jsregexp.cc View 1 chunk +47 lines, -47 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
4 years, 10 months ago (2016-02-01 06:52:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655743002/1
4 years, 10 months ago (2016-02-01 06:55:44 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 07:20:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a6aef2373cc41ca7d62e1bd02cda4cef782aff90 Cr-Commit-Position: refs/heads/master@{#33628}
4 years, 10 months ago (2016-02-01 07:21:01 UTC) #8
brucedawson
4 years, 10 months ago (2016-02-01 17:16:22 UTC) #9
Message was sent while issue was closed. 
Thanks for the cleanup. lgtm

Powered by Google App Engine
This is Rietveld 408576698