Issue 16557009: Fix drover.py typo from r204545: TRUE -> True

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16557009: Fix drover.py typo from r204545: TRUE -> True (Closed)

Created:
7 years, 6 months ago by tapted

Modified:
7 years, 6 months ago

Reviewers:
laforge, kerz_chromium

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix typo from r204545: TRUE -> True BUG=None TBR=laforge@chromium.org, kerz Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204668

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	drover.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tapted

Committed patchset #1 manually as r204668 (presubmit successful).

7 years, 6 months ago (2013-06-07 00:06:31 UTC) #2

laforge

7 years, 6 months ago (2013-06-07 00:08:16 UTC) #3

LGTM, thanks for the fix
On Jun 6, 2013 5:01 PM, <tapted@chromium.org> wrote:

> Reviewers: laforge, kerz_chromium,
>
> Description:
> Fix typo from r204545: TRUE -> True
>
> BUG=None
> TBR=laforge@chromium.org, kerz
>
>
> Please review this at
https://codereview.chromium.**org/16557009/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/tools/depot_tools<http://svn.chromium.org/chrome/trunk/tools/depot_tools>
>
> Affected files:
>   M drover.py
>
>
> Index: drover.py
> diff --git a/drover.py b/drover.py
> index 2558f3c6b3aa14b15c99337aeef9d4**c1056f60d1..**
> be3315002ba99f6c192cbe5a22c35d**c7bc26e3f5 100755
> --- a/drover.py
> +++ b/drover.py
> @@ -515,7 +515,7 @@ def drover(options, args):
>      f.close()
>      if FILE_PATTERN:
>        file_pattern_ = FILE_PATTERN
> -    NO_ALT_URLS = TRUE
> +    NO_ALT_URLS = True
>
>    if options.revert and options.branch:
>      print 'Note: --branch is usually not needed for reverts.'
>
>
>

Expand Messages | Collapse Messages