Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 16557002: rebaseline.py self-tests: split test inputs and outputs into completely separate directories (Closed)

Created:
7 years, 6 months ago by epoger
Modified:
7 years, 6 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

rebaseline.py self-tests: split test inputs and outputs into completely separate directories Committed: https://code.google.com/p/skia/source/detail?r=9459

Patch Set 1 #

Total comments: 1

Patch Set 2 : split_input_and_output_dirs #

Total comments: 2

Patch Set 3 : sync_to_r9458 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -828 lines) Patch
M tools/tests/rebaseline.sh View 1 2 3 chunks +32 lines, -13 lines 0 comments Download
D tools/tests/rebaseline/all/output-expected/command_line View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/all/output-expected/return_value View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/all/output-expected/stdout View 1 2 1 chunk +0 lines, -742 lines 0 comments Download
M + tools/tests/rebaseline/output/using-json1/output-expected/command_line View 1 1 chunk +1 line, -1 line 0 comments Download
M + tools/tests/rebaseline/output/using-json1/output-expected/stdout View 1 2 chunks +2 lines, -2 lines 0 comments Download
D tools/tests/rebaseline/subset/output-expected/command_line View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/subset/output-expected/return_value View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/subset/output-expected/stdout View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D tools/tests/rebaseline/using-json/base-android-galaxy-nexus/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/base-android-galaxy-nexus/actual-results.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/tests/rebaseline/using-json/base-macmini/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/base-macmini/actual-results.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/tests/rebaseline/using-json/base-shuttle-win7-intel-float/Test-Win7-ShuttleA-HD2000-x86-Release/base-shuttle-win7-intel-float/actual-results.json View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
D tools/tests/rebaseline/using-json/output-expected/command_line View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/using-json/output-expected/return_value View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D tools/tests/rebaseline/using-json/output-expected/stdout View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M tools/tests/run.sh View 1 2 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
epoger
https://codereview.chromium.org/16557002/diff/1/tools/tests/rebaseline.sh File tools/tests/rebaseline.sh (right): https://codereview.chromium.org/16557002/diff/1/tools/tests/rebaseline.sh#newcode24 tools/tests/rebaseline.sh:24: EXPECTED_FILES=$(find $1/*/output-expected -type f | grep -v /\.svn/) Patchset ...
7 years, 6 months ago (2013-06-06 14:41:24 UTC) #1
epoger
https://codereview.chromium.org/16557002/diff/4001/tools/tests/rebaseline/output/using-json1/output-expected/stdout File tools/tests/rebaseline/output/using-json1/output-expected/stdout (right): https://codereview.chromium.org/16557002/diff/4001/tools/tests/rebaseline/output/using-json1/output-expected/stdout#newcode1 tools/tests/rebaseline/output/using-json1/output-expected/stdout:1: # Getting files to rebaseline from JSON summary URL ...
7 years, 6 months ago (2013-06-06 14:58:51 UTC) #2
epoger
7 years, 6 months ago (2013-06-06 15:11:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r9459 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698