Update svg's root paint offset property during paint

Update svg's root paint offset property during paint

This patch updates the paint walk to update properties for SVG's
root which exists at the html->svg boundary. Paint properties are
typically updated in PaintLayerPainter but svg's root does not always
create a paint layer. A followup patch will update transform paint
properties created within SVG that may not have a PaintLayer either.

BUG=537409
Committed: https://crrev.com/2fef7d618c96290323aa9f5a8f9bbabef7037aec
Cr-Commit-Position: refs/heads/master@{#373279}

[pdr., 2016-01-30 03:57:50]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-30 03:58:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1655553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1655553002/1

[pdr., 2016-01-30 04:00:20]

Description was changed from

==========
Update paint properties while painting objects without paint layers

This patch updates the paint walk to update properties for layout
objects that haven't created a PaintLayer such as SVGRoot which
creates a paint offset transform for all children.

This infrastructure will be used for all properties that do not create
PaintLayers.
==========

to

==========
Update paint properties while painting objects without paint layers

This patch updates the paint walk to update properties for layout
objects that haven't created a PaintLayer such as SVGRoot which
creates a paint offset transform for all children.

This infrastructure will be used for all properties that do not create
PaintLayers.

Some alternatives to this approach:
1) Special-case SVGRootPainter for now
2) Move this logic into recorders (TransformRecorder, etc).
==========

[pdr., 2016-01-30 05:00:39]

pdr@chromium.org changed reviewers:
+ jbroman@chromium.org, trchen@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:05:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-30 06:05:49]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-02-01 16:44:20]

https://codereview.chromium.org/1655553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1655553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h:34:
Optional<ScopedPaintChunkProperties> propertyScope;
I'm not convinced LayoutObjectDrawingRecorder is the right home, nor would I
expect a boolean-returning method called "use cached drawing if possible" to
have this effect. I'd rather the callers which expect this set paint chunk
properties outside this, especially since it would be reasonable for it to span
multiple drawings.

A helper may be useful if this logic is common to multiple callers, but this
looks odd to me.

[trchen, 2016-02-02 01:34:48]

https://codereview.chromium.org/1655553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h (right):

https://codereview.chromium.org/1655553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/LayoutObjectDrawingRecorder.h:84: //
properties, as PaintLayerPainter will handle all other cases.
This statement is not true. For example, a PaintLayer needs to apply itself with
all overflow clip/scroll imposed by its positional ancestors, but not overflow
clip from itself. Its normal flow contents still need to apply overflow clip
during paint walk. See: https://codereview.chromium.org/1652313003/

I haven't looked at all cases, but we probably can't apply all properties
blindly at a single place. For example, some display items are subject to
overflow clip, but not being scrolled.

[pdr., 2016-02-02 04:18:00]

Description was changed from

==========
Update paint properties while painting objects without paint layers

This patch updates the paint walk to update properties for layout
objects that haven't created a PaintLayer such as SVGRoot which
creates a paint offset transform for all children.

This infrastructure will be used for all properties that do not create
PaintLayers.

Some alternatives to this approach:
1) Special-case SVGRootPainter for now
2) Move this logic into recorders (TransformRecorder, etc).
==========

to

==========
Update svg's root paint offset property during paint

This patch updates the paint walk to update properties for SVG's
root which exists at the html->svg boundary. Paint properties are
typically updated in PaintLayerPainter but svg's root does not always
create a paint layer. A followup patch will update transform paint
properties created within SVG that may not have a PaintLayer either.

BUG=537409
==========

[pdr., 2016-02-02 04:18:08]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-02 04:18:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1655553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1655553002/20001

[commit-bot: I haz the power, 2016-02-02 05:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-02 05:42:13]

Dry run: This issue passed the CQ dry run.

[pdr., 2016-02-02 06:21:31]

Thanks all. In the latest patch I've switched to just updating the properties
for SVGRoot.

PTAL

[jbroman, 2016-02-03 15:06:03]

lgtm

[pdr., 2016-02-03 16:45:23]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-02-03 16:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1655553002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1655553002/20001

[commit-bot: I haz the power, 2016-02-03 18:38:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-03 18:39:19]

Description was changed from

==========
Update svg's root paint offset property during paint

This patch updates the paint walk to update properties for SVG's
root which exists at the html->svg boundary. Paint properties are
typically updated in PaintLayerPainter but svg's root does not always
create a paint layer. A followup patch will update transform paint
properties created within SVG that may not have a PaintLayer either.

BUG=537409
==========

to

==========
Update svg's root paint offset property during paint

This patch updates the paint walk to update properties for SVG's
root which exists at the html->svg boundary. Paint properties are
typically updated in PaintLayerPainter but svg's root does not always
create a paint layer. A followup patch will update transform paint
properties created within SVG that may not have a PaintLayer either.

BUG=537409

Committed: https://crrev.com/2fef7d618c96290323aa9f5a8f9bbabef7037aec
Cr-Commit-Position: refs/heads/master@{#373279}
==========

[commit-bot: I haz the power, 2016-02-03 18:39:20]

Patchset 2 (id:??) landed as
https://crrev.com/2fef7d618c96290323aa9f5a8f9bbabef7037aec
Cr-Commit-Position: refs/heads/master@{#373279}