Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1420)

Unified Diff: remoting/protocol/client_video_dispatcher_unittest.cc

Issue 1655433002: Remove done notifications from incoming message handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/client_video_dispatcher.cc ('k') | remoting/protocol/host_control_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/client_video_dispatcher_unittest.cc
diff --git a/remoting/protocol/client_video_dispatcher_unittest.cc b/remoting/protocol/client_video_dispatcher_unittest.cc
index 2c2abdd67d848f5f1aae7404979670c777eb6e0e..732fecbf92a16d270fd3e43194205648c1c6dbaa 100644
--- a/remoting/protocol/client_video_dispatcher_unittest.cc
+++ b/remoting/protocol/client_video_dispatcher_unittest.cc
@@ -35,7 +35,7 @@ class ClientVideoDispatcherTest : public testing::Test,
ErrorCode error) override;
protected:
- void OnVideoAck(scoped_ptr<VideoAck> ack, const base::Closure& done);
+ void OnVideoAck(scoped_ptr<VideoAck> ack);
void OnReadError(int error);
base::MessageLoop message_loop_;
@@ -97,10 +97,8 @@ void ClientVideoDispatcherTest::OnChannelError(
FAIL();
}
-void ClientVideoDispatcherTest::OnVideoAck(scoped_ptr<VideoAck> ack,
- const base::Closure& done) {
+void ClientVideoDispatcherTest::OnVideoAck(scoped_ptr<VideoAck> ack) {
ack_messages_.push_back(ack.release());
- done.Run();
}
void ClientVideoDispatcherTest::OnReadError(int error) {
« no previous file with comments | « remoting/protocol/client_video_dispatcher.cc ('k') | remoting/protocol/host_control_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698