Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: remoting/protocol/client_control_dispatcher.cc

Issue 1655433002: Remove done notifications from incoming message handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/client_control_dispatcher.h ('k') | remoting/protocol/client_video_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/client_control_dispatcher.cc
diff --git a/remoting/protocol/client_control_dispatcher.cc b/remoting/protocol/client_control_dispatcher.cc
index 2005342c5542f17225229b97aa4ee6e12c244b86..3ce2f95d619667ff340599cdbf985a5897881f6a 100644
--- a/remoting/protocol/client_control_dispatcher.cc
+++ b/remoting/protocol/client_control_dispatcher.cc
@@ -8,7 +8,6 @@
#include "base/bind_helpers.h"
#include "base/callback.h"
-#include "base/callback_helpers.h"
#include "net/socket/stream_socket.h"
#include "remoting/base/constants.h"
#include "remoting/proto/control.pb.h"
@@ -65,11 +64,9 @@ ClientControlDispatcher::ClientControlDispatcher()
clipboard_stub_(nullptr),
parser_(base::Bind(&ClientControlDispatcher::OnMessageReceived,
base::Unretained(this)),
- reader()) {
-}
+ reader()) {}
-ClientControlDispatcher::~ClientControlDispatcher() {
-}
+ClientControlDispatcher::~ClientControlDispatcher() {}
void ClientControlDispatcher::InjectClipboardEvent(
const ClipboardEvent& event) {
@@ -119,11 +116,9 @@ void ClientControlDispatcher::DeliverClientMessage(
}
void ClientControlDispatcher::OnMessageReceived(
- scoped_ptr<ControlMessage> message,
- const base::Closure& done_task) {
+ scoped_ptr<ControlMessage> message) {
DCHECK(client_stub_);
DCHECK(clipboard_stub_);
- base::ScopedClosureRunner done_runner(done_task);
if (message->has_clipboard_event()) {
clipboard_stub_->InjectClipboardEvent(message->clipboard_event());
« no previous file with comments | « remoting/protocol/client_control_dispatcher.h ('k') | remoting/protocol/client_video_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698