Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Unified Diff: remoting/test/protocol_perftest.cc

Issue 1655433002: Remove done notifications from incoming message handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/test/protocol_perftest.cc
diff --git a/remoting/test/protocol_perftest.cc b/remoting/test/protocol_perftest.cc
index bbafe9455247c34cb7744735ed2c99400706eaad..65173121675044e47b95be7e8d2db9f3ec9c390f 100644
--- a/remoting/test/protocol_perftest.cc
+++ b/remoting/test/protocol_perftest.cc
@@ -131,11 +131,11 @@ class ProtocolPerfTest
// protocol::VideoStub interface.
void ProcessVideoPacket(scoped_ptr<VideoPacket> video_packet,
const base::Closure& done) override {
- if (video_packet->data().empty()) {
- // Ignore keep-alive packets
- done.Run();
+ done.Run();
+
+ // Ignore keep-alive packets.
+ if (video_packet->data().empty())
return;
- }
last_video_packet_ = std::move(video_packet);
« remoting/protocol/message_reader.cc ('K') | « remoting/protocol/protobuf_message_parser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698