Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: remoting/protocol/message_reader.h

Issue 1655433002: Remove done notifications from incoming message handlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/message_reader.h
diff --git a/remoting/protocol/message_reader.h b/remoting/protocol/message_reader.h
index 20da39e04b903f971df5eb202d72151266d079ef..4192b12a5caa6c98ac5d3d33ccd324fe65fb0f1f 100644
--- a/remoting/protocol/message_reader.h
+++ b/remoting/protocol/message_reader.h
@@ -35,7 +35,7 @@ class P2PStreamSocket;
// e.g. when we the sender sends multiple messages in one TCP packet.
class MessageReader : public base::NonThreadSafe {
public:
- typedef base::Callback<void(scoped_ptr<CompoundBuffer>, const base::Closure&)>
+ typedef base::Callback<void(scoped_ptr<CompoundBuffer> message)>
MessageReceivedCallback;
typedef base::Callback<void(int)> ReadFailedCallback;
@@ -55,7 +55,6 @@ class MessageReader : public base::NonThreadSafe {
void HandleReadResult(int result, bool* read_succeeded);
void OnDataReceived(net::IOBuffer* data, int data_size);
void RunCallback(scoped_ptr<CompoundBuffer> message);
- void OnMessageDone();
ReadFailedCallback read_failed_callback_;
@@ -65,11 +64,6 @@ class MessageReader : public base::NonThreadSafe {
// OnRead() to be called when new data is received.
bool read_pending_;
- // Number of messages that we received, but haven't finished
- // processing yet, i.e. |done_task| hasn't been called for these
- // messages.
- int pending_messages_;
-
bool closed_;
scoped_refptr<net::IOBuffer> read_buffer_;

Powered by Google App Engine
This is Rietveld 408576698