Remove done notifications from incoming message handlers.

remoting/protocol/client_video_dispatcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/client_video_dispatcher.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 13 matching lines @@
   int frame_id;
   bool done;
 };
 
 ClientVideoDispatcher::ClientVideoDispatcher(VideoStub* video_stub)
     : ChannelDispatcherBase(kVideoChannelName),
       video_stub_(video_stub),
       parser_(base::Bind(&ClientVideoDispatcher::ProcessVideoPacket,
                          base::Unretained(this)),
               reader()),
-      weak_factory_(this) {
-}
+      weak_factory_(this) {}
 
-ClientVideoDispatcher::~ClientVideoDispatcher() {
-}
+ClientVideoDispatcher::~ClientVideoDispatcher() {}
 
 void ClientVideoDispatcher::ProcessVideoPacket(
-    scoped_ptr<VideoPacket> video_packet,
-    const base::Closure& done) {
-  base::ScopedClosureRunner done_runner(done);
-
+    scoped_ptr<VideoPacket> video_packet) {
   int frame_id = video_packet->frame_id();
 
   if (!video_packet->has_frame_id()) {
     video_stub_->ProcessVideoPacket(std::move(video_packet),
-                                    done_runner.Release());
+                                    base::Bind(&base::DoNothing));

[Jamie, 2016/01/29 23:48:12]

Similarly here, can you remove the callback parameter?

[Sergey Ulanov, 2016/01/30 00:14:47]

VideoStub is used on the sender side, and this callback is still useful there,
particularly to measure send latency.

     return;
   }
 
   PendingFramesList::iterator pending_frame =
       pending_frames_.insert(pending_frames_.end(), PendingFrame(frame_id));
 
   video_stub_->ProcessVideoPacket(
       std::move(video_packet),
       base::Bind(&ClientVideoDispatcher::OnPacketDone,
                  weak_factory_.GetWeakPtr(), pending_frame));
@@ skipping 10 matching lines @@
   while (!pending_frames_.empty() && pending_frames_.front().done) {
     VideoAck ack_message;
     ack_message.set_frame_id(pending_frames_.front().frame_id);
     writer()->Write(SerializeAndFrameMessage(ack_message), base::Closure());
     pending_frames_.pop_front();
   }
 }
 
 }  // namespace protocol
 }  // namespace remoting